« back to discussion

Linus Torvalds' views on GitHub's pull requests.

https://github.com/torvalds/linux/pull/17#issuecomment-5654674

Interesting insight from the grandmaster himself!

almost 4 years ago, by lush

5 Replies

pineapple

Haha, wow

pineapple, almost 4 years ago

SkinnyGeek1010

Haha wow what a troll fest.... I didn't make it to the end but bookmarked a halfway point lol.

I can see his point about having high standards for the linux repository, but I don't really see what the big deal is about the web merge, or at least at present. They have shortlog area and a longer description box, although they could do with a line char counter.
github merge req

I also do not see what the difference is between web patches and normal git ones... these two look the same to me (well besides the latter having a one liner message lol):

https://github.com/torvalds/linux/commit/db1b2d323f7914452db5a7071e75f3d159ac6e5d.patch
https://github.com/jesusabdullah/hoarders/commit/492d5e28e7d48d2404fde4da56eee9d0f4056225.patch

I do dislike when people leave short one liners (or worse, long one liners) for the commit message, so I can see his point there. This does make me want to go back and squash and rebase my commits with better messages before pushing them... lately mine have been very short lol.

SkinnyGeek1010, almost 4 years ago

blueberry
posted by SkinnyGeek1010 on Fri, Feb 15 at 10:59PM

snip

That's awesome how you made an image a link with MD... I was wondering how you do that

blueberry, almost 4 years ago

pineapple

The more i read through this the more I love it. He really likes the word invariably

pineapple, almost 4 years ago

SkinnyGeek1010
posted by blueberry on Sat, Feb 16 at 12:03AM

That's awesome how you made an image a link with MD... I was wondering how you do that

LOL, I was wondering if anyone would even notice that. Its just a MD image wrapped in a MD link, with the MD imagine inside the links [ ] brackets.
[ ![img caption](linktoimage.png) ](linktoimage.png)

SkinnyGeek1010, almost 4 years ago


Login or to comment.

« back to discussion

Tutorials are any resources you learn from.

Examples: an intro to html5 screencast, a pdf about git, photoshop effects tutorials, meta-programming in ruby, lambda calculus, higher-order fixed-point combinators.

Tools are websites, apps or services used -on- your project (indirectly), to aid the process.

Examples: A color scheme generator, email marketing software, usability heat maps, css3 code generators, a downloadable png compressor.

Assets are downloadable files used -in- your projects, usually as code, textures, or images.

Examples: a jquery sticky menu, photoshop brushes, background textures, mvc frameworks, twitter bootstrap, 960 grid system.